Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Remove unnecessary comment from Observable.timeInterval(TimeUnit) #5858

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

zhukic
Copy link
Contributor

@zhukic zhukic commented Feb 18, 2018

No description provided.

Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also check that Flowable.timeInterval as well as the other timeInterval and timestamped don't have such incorrect comment?

@zhukic
Copy link
Contributor Author

zhukic commented Feb 18, 2018

@akarnokd I've checked. It's ok.

@codecov
Copy link

codecov bot commented Feb 18, 2018

Codecov Report

Merging #5858 into 2.x will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #5858      +/-   ##
===========================================
+ Coverage     96.43%   96.5%   +0.07%     
- Complexity     5834    5837       +3     
===========================================
  Files           640     640              
  Lines         41944   41944              
  Branches       5804    5804              
===========================================
+ Hits          40449   40479      +30     
+ Misses          584     560      -24     
+ Partials        911     905       -6
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 512 <0> (ø) ⬇️
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...io/reactivex/subscribers/SerializedSubscriber.java 94.31% <0%> (-1.14%) 25% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.65% <0%> (-1.09%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-0.97%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 97.54% <0%> (-0.82%) 2% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 85.52% <0%> (-0.66%) 3% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 90% <0%> (-0.63%) 3% <0%> (ø)
...x/internal/operators/flowable/FlowableGroupBy.java 94.39% <0%> (-0.63%) 2% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74504f...4ad77cd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants