2.x: Detail distinct() & distinctUntilChanged() in JavaDoc #5837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
force-pushed
the
DistinctUntilChangedClarification
branch
from
254ae70
to
4d043b2
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #5837 +/- ##
===========================================
+ Coverage 96.39% 96.4% +<.01%
- Complexity 5813 5817 +4
===========================================
Files 634 634
Lines 41760 41760
Branches 5796 5796
===========================================
+ Hits 40256 40257 +1
+ Misses 583 578 -5
- Partials 921 925 +4
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Feb 2, 2018
artem-zinnatullin
approved these changes
Feb 2, 2018
| * It is recommended the elements' class {@code T} in the flow overrides the default {@code Object.equals()} to provide | ||
| * meaningful comparison between items as the default Java implementation only considers reference equivalence. | ||
| * <p> | ||
| * By default, {@code distinct()} uses an internal, per Subscriber {@link java.util.HashSet} to remember |
There was a problem hiding this comment.
supernit: could be phrased like that By default, {@code distinct()} uses an internal {@link java.util.HashSet} per Subscriber to remember
| * <p> | ||
| * <img width="640" height="310" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/distinct.png" alt=""> | ||
| * <p> | ||
| * It is recommended the elements' class {@code T} in the flow overrides the default {@code Object.equals()} to provide |
There was a problem hiding this comment.
Since we use HashSet internally, we should probably recommend properly overriding hasCode() as well
vanniktech
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR clarifies the comparison and retention behavior of the
distinctanddistinctUntilChangedoperators (in bothFlowableandObservable).