Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Improve the wording of the share() JavaDocs #5824

Merged
merged 2 commits into from
Jan 28, 2018

Conversation

akarnokd
Copy link
Member

This PR improves the wording of the Flowable.share() and Observable.share() operators and fixes a JavaDoc link display mistake:

image

@akarnokd akarnokd added this to the 2.2 milestone Jan 26, 2018
@codecov
Copy link

codecov bot commented Jan 26, 2018

Codecov Report

Merging #5824 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #5824   +/-   ##
=========================================
  Coverage     96.38%   96.38%           
+ Complexity     5816     5811    -5     
=========================================
  Files           634      634           
  Lines         41761    41761           
  Branches       5796     5796           
=========================================
  Hits          40253    40253           
+ Misses          583      579    -4     
- Partials        925      929    +4
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 509 <0> (ø) ⬇️
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 526 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-5.98%) 2% <0%> (ø)
.../io/reactivex/internal/functions/ObjectHelper.java 94.73% <0%> (-5.27%) 20% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 91.03% <0%> (-4.04%) 60% <0%> (+1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 92.3% <0%> (-2.57%) 6% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 61.53% <0%> (-2.57%) 12% <0%> (-1%)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...nternal/operators/parallel/ParallelSortedJoin.java 92.75% <0%> (-2.18%) 2% <0%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173156d...3b8db09. Read the comment docs.

Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

@@ -10493,11 +10493,11 @@ public final void safeSubscribe(Observer<? super T> s) {
}

/**
* Returns a new {@link ObservableSource} that multicasts (shares) the original {@link ObservableSource}. As long as
* Returns a new {@link ObservableSource} that multicasts (abd shares a single subscription to) the original {@link ObservableSource}. As long as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"abd" -> "and"

@akarnokd akarnokd merged commit 3f6e595 into ReactiveX:2.x Jan 28, 2018
@akarnokd akarnokd deleted the ShareJavadocClarify branch January 28, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants