-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Improve the wording of the share() JavaDocs #5824
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5824 +/- ##
=========================================
Coverage 96.38% 96.38%
+ Complexity 5816 5811 -5
=========================================
Files 634 634
Lines 41761 41761
Branches 5796 5796
=========================================
Hits 40253 40253
+ Misses 583 579 -4
- Partials 925 929 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo
@@ -10493,11 +10493,11 @@ public final void safeSubscribe(Observer<? super T> s) { | |||
} | |||
|
|||
/** | |||
* Returns a new {@link ObservableSource} that multicasts (shares) the original {@link ObservableSource}. As long as | |||
* Returns a new {@link ObservableSource} that multicasts (abd shares a single subscription to) the original {@link ObservableSource}. As long as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"abd" -> "and"
This PR improves the wording of the
Flowable.share()
andObservable.share()
operators and fixes a JavaDoc link display mistake: