Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add missing {Maybe|Single}.mergeDelayError variants #5799

Merged
merged 2 commits into from
Jan 9, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 9, 2018

This PR adds mergeDelayError overloads to Maybe and Single; the infrastructure was there from the beginning but the delayErrors == true settings were not exposed publicly.

  • Maybe.mergeDelayError(Publisher, int)
  • Single.mergeDelayError(Iterable)
  • Single.mergeDelayError(Publisher)
  • Single.mergeDelayError(SingleSource, SingleSource)
  • Single.mergeDelayError(SingleSource, SingleSource, SingleSource)
  • Single.mergeDelayError(SingleSource, SingleSource, SingleSource, SingleSource)

@akarnokd akarnokd added this to the 2.2 milestone Jan 9, 2018
*
* @param <T> the common value type
* @param source1
* a Single to be merged
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically it's a SingleSource. dunno whether you want to distinguish between them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it as Maybe.merge() say "a MaybeSource to be merged".

@codecov
Copy link

codecov bot commented Jan 9, 2018

Codecov Report

Merging #5799 into 2.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #5799      +/-   ##
===========================================
+ Coverage     96.29%   96.3%   +<.01%     
- Complexity     5808    5812       +4     
===========================================
  Files           634     634              
  Lines         41631   41647      +16     
  Branches       5776    5776              
===========================================
+ Hits          40090   40108      +18     
+ Misses          605     597       -8     
- Partials        936     942       +6
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <100%> (ø) 142 <5> (+5) ⬆️
src/main/java/io/reactivex/Maybe.java 100% <100%> (ø) 171 <1> (+1) ⬆️
.../operators/flowable/FlowableBlockingSubscribe.java 91.89% <0%> (-5.41%) 9% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 60.41% <0%> (-4.17%) 34% <0%> (-3%)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 95.72% <0%> (-2.57%) 2% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-1.31%) 2% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adb1fa...be2d913. Read the comment docs.

@akarnokd akarnokd merged commit f00533c into ReactiveX:2.x Jan 9, 2018
@akarnokd akarnokd deleted the MergeOverloads branch January 9, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants