Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Observable.replay(Function, ...) marble fixes #5798

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 9, 2018

This PR updates the marble diagrams of the 8 Observable.replay() overload that take a Function and various other parameters:

Images in #5319 (comment) .

@akarnokd akarnokd added this to the 2.2 milestone Jan 9, 2018
@codecov
Copy link

codecov bot commented Jan 9, 2018

Codecov Report

Merging #5798 into 2.x will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #5798      +/-   ##
===========================================
- Coverage     96.3%   96.26%   -0.04%     
- Complexity    5807     5808       +1     
===========================================
  Files          634      634              
  Lines        41631    41631              
  Branches      5776     5776              
===========================================
- Hits         40094    40078      -16     
- Misses         598      611      +13     
- Partials       939      942       +3
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 509 <0> (ø) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-5.8%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 91.03% <0%> (-4.94%) 60% <0%> (ø)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-3.23%) 9% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-2.99%) 2% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 60.41% <0%> (-1.39%) 34% <0%> (-1%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed3e5e...3317614. Read the comment docs.

@akarnokd akarnokd merged commit 2adb1fa into ReactiveX:2.x Jan 9, 2018
@akarnokd akarnokd deleted the Marbles0109a branch January 9, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants