Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: More marbles 01/08-a #5795

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 8, 2018

This PR adds 5 marble diagrams to Observable:

  • flatMapCompletable (2 overloads)
  • forEach
  • forEachWhile
  • hide

Images in #5319 (comment)

@codecov
Copy link

codecov bot commented Jan 8, 2018

Codecov Report

Merging #5795 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5795      +/-   ##
============================================
+ Coverage     96.29%   96.32%   +0.03%     
+ Complexity     5808     5807       -1     
============================================
  Files           634      634              
  Lines         41631    41631              
  Branches       5776     5776              
============================================
+ Hits          40089    40102      +13     
+ Misses          602      590      -12     
+ Partials        940      939       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 509 <0> (ø) ⬇️
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...io/reactivex/subscribers/SerializedSubscriber.java 94.31% <0%> (-1.14%) 25% <0%> (-1%)
...ivex/internal/operators/maybe/MaybeMergeArray.java 96.62% <0%> (-1.13%) 6% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 95.06% <0%> (-0.9%) 59% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 96.58% <0%> (-0.86%) 2% <0%> (ø)
...tors/observable/ObservableSequenceEqualSingle.java 98.29% <0%> (-0.86%) 3% <0%> (ø)
...ain/java/io/reactivex/subjects/UnicastSubject.java 97.46% <0%> (-0.64%) 60% <0%> (-1%)
...nternal/operators/observable/ObservableReplay.java 98.05% <0%> (-0.56%) 23% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1c705...f6596d5. Read the comment docs.

@akarnokd akarnokd merged commit 732927c into ReactiveX:2.x Jan 8, 2018
@akarnokd akarnokd deleted the ObservableMarbles0108 branch January 8, 2018 12:08
@akarnokd akarnokd added this to the 2.2 milestone Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants