2.x: add error handling section to merge() operator docs #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5786 +/- ##
============================================
- Coverage 96.29% 96.23% -0.07%
Complexity 5809 5809
============================================
Files 634 634
Lines 41607 41629 +22
Branches 5770 5775 +5
============================================
- Hits 40066 40062 -4
- Misses 614 630 +16
- Partials 927 937 +10
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jan 3, 2018
artem-zinnatullin
approved these changes
Jan 5, 2018
| * first one's error or, depending on the concurrency of the sources, may terminate with a | ||
| * {@code CompositeException} containing two or more of the various error signals. | ||
| * {@code Throwable}s that didn't make into the composite will be sent (individually) to the global error handler via | ||
| * {@link RxJavaPlugins#onError(Throwable)} method as <em>undeliverable errors</em>. Similarly, {@code Throwable}s |
There was a problem hiding this comment.
nit: maybe replace <em>undeliverable with <code>UndeliverableException similarly to CompositeException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Error handling JavaDoc section to the other
mergeoperators throughout the base reactive classes.Note though that the following
mergeDelayErrormethods don't exist yet:Maybe.mergeDelayError(Publisher, int)Single.mergeDelayError(*)(*all variants of their respectivemergemethods are missing)These can be added in a separate PR and don't require implementing new operators but to configure existing ones with
delayError == true.