Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: add/update Observable marbles 11/28 #5745

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

@akarnokd akarnokd added this to the 2.2 milestone Nov 28, 2017
@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #5745 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5745      +/-   ##
============================================
- Coverage     96.25%   96.25%   -0.01%     
- Complexity     5833     5837       +4     
============================================
  Files           634      634              
  Lines         41644    41644              
  Branches       5768     5768              
============================================
- Hits          40086    40083       -3     
- Misses          625      627       +2     
- Partials        933      934       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 509 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 84.96% <0%> (-7.19%) 2% <0%> (ø)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 90.29% <0%> (-3.74%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.75% <0%> (-2.18%) 2% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 97.24% <0%> (-1.84%) 39% <0%> (-1%)
...vex/internal/operators/parallel/ParallelRunOn.java 95.65% <0%> (-1.45%) 8% <0%> (ø)
...vex/internal/operators/flowable/FlowableCache.java 93.95% <0%> (-1.35%) 7% <0%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1542b...927eff6. Read the comment docs.

@ZacSweers
Copy link
Contributor

The different colored stars in doOnLifecycle weren't obvious to me, but the rest seems good

@akarnokd akarnokd merged commit 30905fc into ReactiveX:2.x Nov 30, 2017
@akarnokd akarnokd deleted the Marbles1128 branch November 30, 2017 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants