Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Javadocs: add period to custom scheduler use sentences #5717

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

akarnokd
Copy link
Member

There were missing . from sentences in the operator Javadocs detailing certain overloads use custom Schedulers.

@akarnokd akarnokd added this to the 2.2 milestone Nov 10, 2017
@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #5717 into 2.x will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5717      +/-   ##
============================================
- Coverage     96.33%   96.27%   -0.07%     
+ Complexity     5820     5819       -1     
============================================
  Files           634      634              
  Lines         41604    41604              
  Branches       5761     5761              
============================================
- Hits          40079    40053      -26     
- Misses          600      618      +18     
- Partials        925      933       +8
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 508 <0> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 135 <0> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 169 <0> (ø) ⬇️
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 525 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 91.15% <0%> (-3.99%) 62% <0%> (+1%)
...l/operators/observable/ObservableFlatMapMaybe.java 90.84% <0%> (-2.62%) 2% <0%> (ø)
...java/io/reactivex/subjects/CompletableSubject.java 97.4% <0%> (-2.6%) 36% <0%> (-1%)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.71% <0%> (-1.45%) 2% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ddc7a...a0f13a7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants