Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: BaseTestConsumer values() and errors() thread-safety clarifications #5713

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Nov 9, 2017

This PR adds clarifications to the BaseTestConsumer.values() and BaseTestConsumer.errors() method in regard to accessing elements while the upstream is still actively emitting events.

Related discussion: #5712

@akarnokd akarnokd added this to the 2.2 milestone Nov 9, 2017
@akarnokd akarnokd changed the title TestConsumer values() and errors() thread-safety clarifications 2.x: BaseTestConsumer values() and errors() thread-safety clarifications Nov 9, 2017
@akarnokd akarnokd force-pushed the TestConsumerConcurrencyWarnings branch from 942c2bd to f2a12f4 Compare November 9, 2017 13:01
@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #5713 into 2.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5713      +/-   ##
============================================
+ Coverage     96.28%   96.29%   +<.01%     
  Complexity     5822     5822              
============================================
  Files           634      634              
  Lines         41604    41604              
  Branches       5761     5761              
============================================
+ Hits          40060    40064       +4     
+ Misses          616      606      -10     
- Partials        928      934       +6
Impacted Files Coverage Δ Complexity Δ
.../java/io/reactivex/observers/BaseTestConsumer.java 99.65% <ø> (ø) 113 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 86.92% <0%> (-5.89%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-3.81%) 2% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 92.47% <0%> (-2.16%) 9% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...a/io/reactivex/internal/queue/MpscLinkedQueue.java 98.03% <0%> (-1.97%) 17% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 97.24% <0%> (-1.84%) 39% <0%> (-1%)
...ternal/operators/flowable/FlowableSubscribeOn.java 96.61% <0%> (-1.7%) 2% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.75% <0%> (-1.45%) 2% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9ffae...f2a12f4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants