Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x Upgrade testng to fix issue #5641 #5653

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

dweebo
Copy link
Contributor

@dweebo dweebo commented Oct 9, 2017

Fix for #5641

Method names now show up in gradle console when tests are skipped and in testng html output (previously no test names were showing up in html output for skipped or completed tests).

@akarnokd akarnokd added this to the 2.2 milestone Oct 9, 2017
@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #5653 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5653      +/-   ##
============================================
- Coverage     96.21%   96.18%   -0.03%     
  Complexity     5848     5848              
============================================
  Files           635      635              
  Lines         41651    41651              
  Branches       5768     5768              
============================================
- Hits          40074    40062      -12     
- Misses          629      638       +9     
- Partials        948      951       +3
Impacted Files Coverage Δ Complexity Δ
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-5.89%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-3.23%) 9% <0%> (ø)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableTakeLastTimed.java 96.29% <0%> (-2.78%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 96.58% <0%> (-2.57%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 61.53% <0%> (-2.57%) 12% <0%> (-1%)
...rnal/operators/observable/ObservableObserveOn.java 97.95% <0%> (-2.05%) 3% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0cd2a...b019939. Read the comment docs.

akarnokd pushed a commit that referenced this pull request Oct 9, 2017
@akarnokd akarnokd merged commit e02cb58 into ReactiveX:2.x Oct 9, 2017
@akarnokd
Copy link
Member

akarnokd commented Oct 9, 2017

Thanks! I was afraid of 6.10+ because it broke the Reactive-Streams TCK by mandating parameter injection all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants