Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: update Obs.just(2..10) & switchOnNextDelayError marbles #5651

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 9, 2017

This PR updates the marble diagrams of the 2..10 argument Observable.just() and two overloads of Observable.switchOnNextDelayError.

Images in Issue 5319.

@akarnokd akarnokd added this to the 2.2 milestone Oct 9, 2017
@akarnokd akarnokd changed the title 2.x: update Obs.just(2..9) & switchOnNextDelayError marbles 2.x: update Obs.just(2..10) & switchOnNextDelayError marbles Oct 9, 2017
@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #5651 into 2.x will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5651      +/-   ##
============================================
+ Coverage     96.16%   96.21%   +0.04%     
- Complexity     5848     5852       +4     
============================================
  Files           635      635              
  Lines         41652    41652              
  Branches       5768     5768              
============================================
+ Hits          40056    40075      +19     
+ Misses          635      622      -13     
+ Partials        961      955       -6
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 508 <0> (ø) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 92.95% <0%> (-2.65%) 11% <0%> (+1%)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-2.24%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-1.67%) 2% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 93.44% <0%> (-1.64%) 2% <0%> (ø)
...nal/operators/flowable/FlowableConcatMapEager.java 97.1% <0%> (-1.16%) 2% <0%> (ø)
...reactivex/internal/queue/SpscLinkedArrayQueue.java 96.82% <0%> (-0.8%) 38% <0%> (-1%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1cb606...ded155d. Read the comment docs.

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to update the Flowable marbles too?

@akarnokd
Copy link
Member Author

akarnokd commented Oct 9, 2017

Flowable marbles require other adjustments, such as explicit request() indications. I first want Observable's marbles to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants