Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: improve package JavaDoc #5648

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 6, 2017

Add Maybe to the io.reactivex package Javadoc. Reword io.reactivex.observers and io.reactivex.subscribers as there are no utility classes in 2.x in them to create consumers from callbacks (those are internal and offered by the subscribe() overloads only).

@akarnokd akarnokd added this to the 2.2 milestone Oct 6, 2017
@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #5648 into 2.x will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5648      +/-   ##
============================================
- Coverage     96.32%   96.25%   -0.08%     
+ Complexity     5851     5849       -2     
============================================
  Files           634      634              
  Lines         41539    41539              
  Branches       5752     5752              
============================================
- Hits          40014    39983      -31     
- Misses          604      609       +5     
- Partials        921      947      +26
Impacted Files Coverage Δ Complexity Δ
.../operators/observable/ObservableFlatMapSingle.java 90.29% <0%> (-5.23%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 88.88% <0%> (-4.58%) 2% <0%> (ø)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 61.53% <0%> (-2.57%) 12% <0%> (-1%)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 94.27% <0%> (-1.77%) 11% <0%> (ø)
...ternal/operators/flowable/FlowableSubscribeOn.java 96.61% <0%> (-1.7%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.02% <0%> (-1.64%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.68% <0%> (-1.45%) 2% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f10ad8...91ddbc6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants