Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix incorrect error message at SubscriptionHelper.setOnce #5623

Conversation

takuaraki
Copy link
Contributor

I found an incorrect error message at SubscriptionHelper.setOnce.
The error message should mention that the second argument Subscription s is null, but the error message says "d is null".

@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #5623 into 2.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #5623      +/-   ##
===========================================
- Coverage     96.21%   96.2%   -0.01%     
+ Complexity     5846    5842       -4     
===========================================
  Files           632     632              
  Lines         41476   41476              
  Branches       5746    5746              
===========================================
- Hits          39905   39903       -2     
+ Misses          626     620       -6     
- Partials        945     953       +8
Impacted Files Coverage Δ Complexity Δ
...vex/internal/subscriptions/SubscriptionHelper.java 100% <100%> (ø) 36 <3> (ø) ⬇️
...erators/flowable/FlowableOnBackpressureLatest.java 94.59% <0%> (-5.41%) 2% <0%> (ø)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 94.87% <0%> (-2.57%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.2% <0%> (-2.42%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 97.24% <0%> (-1.84%) 39% <0%> (-1%)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad8ca8e...f73593b. Read the comment docs.

@akarnokd akarnokd merged commit 8c5bd1d into ReactiveX:2.x Sep 27, 2017
@akarnokd
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants