Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix Observable.delay & Flowable.delay javadoc #5617

Merged
merged 1 commit into from
Sep 24, 2017

Conversation

PhilGlass
Copy link
Contributor

Error notifications can be delayed when using the overloads with a delayError parameter.

@akarnokd akarnokd added this to the 2.2 milestone Sep 23, 2017
@codecov
Copy link

codecov bot commented Sep 23, 2017

Codecov Report

Merging #5617 into 2.x will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #5617      +/-   ##
===========================================
- Coverage     96.27%   96.2%   -0.08%     
+ Complexity     5844    5839       -5     
===========================================
  Files           632     632              
  Lines         41473   41473              
  Branches       5745    5745              
===========================================
- Hits          39929   39898      -31     
- Misses          617     628      +11     
- Partials        927     947      +20
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 523 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 506 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 91.89% <0%> (-5.41%) 9% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 94.87% <0%> (-4.28%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-3.81%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 92.98% <0%> (-3.51%) 11% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-3.23%) 9% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.75% <0%> (-2.18%) 2% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
...vex/internal/subscribers/QueueDrainSubscriber.java 50% <0%> (-1.57%) 15% <0%> (-1%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e33000...7cc75a5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants