Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating JavaDoc with correct return types #5600

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Updating JavaDoc with correct return types #5600

merged 1 commit into from
Sep 14, 2017

Conversation

levaja
Copy link
Contributor

@levaja levaja commented Sep 14, 2017

A small PR with updated JavaDoc, mentioned in the issue #5595 (thanks to @RobLewis for reporting it).

Updated documentation about return types, where Observable was incorrectly mentioned instead of Single.

Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@akarnokd
Copy link
Member

The Flowable variants are okay.

@akarnokd akarnokd added this to the 2.2 milestone Sep 14, 2017
@codecov
Copy link

codecov bot commented Sep 14, 2017

Codecov Report

Merging #5600 into 2.x will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #5600      +/-   ##
===========================================
- Coverage     96.2%   96.15%   -0.06%     
- Complexity    5838     5840       +2     
===========================================
  Files          632      632              
  Lines        41473    41473              
  Branches      5745     5745              
===========================================
- Hits         39898    39877      -21     
- Misses         632      637       +5     
- Partials       943      959      +16
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 506 <0> (ø) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-6.77%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 60.28% <0%> (-4.26%) 32% <0%> (-3%)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...vex/internal/operators/single/SingleTakeUntil.java 91.8% <0%> (-3.28%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 93.28% <0%> (-2.99%) 2% <0%> (ø)
...rnal/operators/observable/ObservableObserveOn.java 97.95% <0%> (-2.05%) 3% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a620a...97ad2a2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants