-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Try fixing Travis CI lack of java #5531
Conversation
Why not move the build to JDK 8?
…On Tue, Aug 1, 2017 at 4:27 PM David Karnok ***@***.***> wrote:
Looks like Trusty only supports Java 8 builds:
[image: image]
<https://user-images.githubusercontent.com/1269832/28845459-639c07b8-7708-11e7-8a8d-10ffaefb4acf.png>
There is also a test failure of MaybeFromRunnableTest.noErrorLoss due to
being sensitive to delays.
Forcing dist: precise works.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5531 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEWTjqZfnSbLVMBFyonViJluDj9pGks5sT4obgaJpZM4OqOt3>
.
|
Codecov Report
@@ Coverage Diff @@
## 2.x #5531 +/- ##
============================================
+ Coverage 96.14% 96.18% +0.03%
- Complexity 5806 5822 +16
============================================
Files 631 631
Lines 41285 41405 +120
Branches 5732 5737 +5
============================================
+ Hits 39693 39824 +131
- Misses 629 630 +1
+ Partials 963 951 -12
Continue to review full report at Codecov.
|
It is an option; there was already a switch to oraclejdk7 back when the JDK 6 support dropped. Should we switch to |
That's what I use on all our projects which target Java 6 compatibility. We
use JDK 8 and then Animal Sniffer to ensure no Java 8 APIs are referenced.
It'll be nice when Java 9 comes out and its "-release 6" flag can be used
to accomplish this.
…On Tue, Aug 1, 2017 at 4:41 PM David Karnok ***@***.***> wrote:
It is an option; there was already a switch to oraclejdk7 back when the
JDK 6 support dropped.
Should we switch to oraclejdk8 and run on trusty?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5531 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEERLUOx8rYuhszj2QPRSyOJD5xK_Iks5sT41ygaJpZM4OqOt3>
.
|
I'd propose switching build to Docker where we can better control what environment is actually in the build and test against multiple versions of JDK properly (if needed). Also with Docker we'll be able to reproduce CI builds very precisely (except hardware limits). |
That's too risky and may not work due to the encrypted credentials we have here for maven upload. |
I don't see problems with that, both files and environment variables can be easily passed to Docker container so that should solve maven upload. And I actually think that keeping environment under Travis control (they update things) is more dangerous. |
* 2.x: Try fixing Travis CI lack of java * Force dist: precise * Oracle JDK 8 is then
* Add assertValueAt(int, value) to TestObserver * Fix test to call correct method * David's comments * Artem's comments * 2.x: Try fixing Travis CI lack of java (#5531) * 2.x: Try fixing Travis CI lack of java * Force dist: precise * Oracle JDK 8 is then
Travis CI has replaced the previous Precise image with the Trusty image as part of an ongoing rollout. Unfortunately, the Trusty image fails for
oraclejdk7
because probably it is no longer supported (although I couldn't find anything about it).This PR tries to identify what's available by trying a matrix of build setups.