Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: FlowableTimeoutTimed - replace AtomicReference with mutable field #5466

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

davidmoten
Copy link
Collaborator

As per discussion in #5461. The timer fields in the Subscriber classes in FlowableTimeoutTimed are AtomicReferences but this is not required as the fields are accessed synchronously.

The timer field in TimeoutTimedOtherSubscriber did require an AtomicReference because of the dispose call here but this call is not required if we just call worker.dispose().

No unit test additions.

P.S. 9321 unit tests in RxJava 2.x! An outrageous amount of work, thanks @akarnokd (and other contributors)!

@akarnokd akarnokd added this to the 2.2 milestone Jul 5, 2017
@codecov
Copy link

codecov bot commented Jul 5, 2017

Codecov Report

Merging #5466 into 2.x will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5466      +/-   ##
============================================
- Coverage     95.94%   95.91%   -0.04%     
- Complexity     5797     5801       +4     
============================================
  Files           631      631              
  Lines         41306    41297       -9     
  Branches       5745     5743       -2     
============================================
- Hits          39633    39610      -23     
- Misses          656      669      +13     
- Partials       1017     1018       +1
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/flowable/FlowableTimeoutTimed.java 93.22% <100%> (+1.09%) 4 <0> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 92.3% <0%> (-5.99%) 2% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 86.88% <0%> (-4.92%) 2% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <0%> (-4.62%) 27% <0%> (-1%)
...ternal/operators/flowable/FlowableSampleTimed.java 91.17% <0%> (-4.42%) 3% <0%> (ø)
...ernal/operators/maybe/MaybeTakeUntilPublisher.java 96% <0%> (-4%) 2% <0%> (ø)
...internal/disposables/ArrayCompositeDisposable.java 96.42% <0%> (-3.58%) 15% <0%> (-1%)
...ex/internal/subscriptions/SubscriptionArbiter.java 95.76% <0%> (-3.39%) 45% <0%> (-2%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 91.3% <0%> (-3.27%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 82.81% <0%> (-3.13%) 56% <0%> (-1%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08be741...2976482. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants