2.x: FlowableTimeoutTimed - replace AtomicReference with mutable field #5466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #5461. The timer fields in the Subscriber classes in FlowableTimeoutTimed are
AtomicReference
s but this is not required as the fields are accessed synchronously.The
timer
field inTimeoutTimedOtherSubscriber
did require anAtomicReference
because of the dispose call here but this call is not required if we just callworker.dispose()
.No unit test additions.
P.S. 9321 unit tests in RxJava 2.x! An outrageous amount of work, thanks @akarnokd (and other contributors)!