Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2x: Fix wording in Async and Publish processors javadoc. #5444

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

serj-lotutovici
Copy link
Contributor

Seams that these are some leftovers from the 1.x -> 2.x refactoring.

@@ -23,14 +23,14 @@
import io.reactivex.plugins.RxJavaPlugins;

/**
* A Subject that multicasts events to Subscribers that are currently subscribed to it.
* Processor that multicasts all subsequently observed items to its current {@link Subscriber}s.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A Processor" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Replay and Behaviour processors it's "Processor" _(ツ)_/¯. Both seam syntactically correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the AsyncProcessor could be adjusted as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #5444 into 2.x will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5444      +/-   ##
============================================
+ Coverage     95.96%   96.04%   +0.07%     
- Complexity     5793     5794       +1     
============================================
  Files           631      631              
  Lines         41297    41297              
  Branches       5744     5744              
============================================
+ Hits          39632    39662      +30     
+ Misses          663      654       -9     
+ Partials       1002      981      -21
Impacted Files Coverage Δ Complexity Δ
...n/java/io/reactivex/processors/AsyncProcessor.java 99.15% <ø> (ø) 56 <0> (ø) ⬇️
...java/io/reactivex/processors/PublishProcessor.java 98.29% <ø> (ø) 45 <0> (ø) ⬇️
...a/io/reactivex/processors/SerializedProcessor.java 89.36% <0%> (-8.52%) 26% <0%> (-2%)
.../java/io/reactivex/subjects/SerializedSubject.java 87.36% <0%> (-8.43%) 25% <0%> (-2%)
...vex/internal/operators/single/SingleTakeUntil.java 88.52% <0%> (-6.56%) 2% <0%> (ø)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...perators/flowable/FlowableSequenceEqualSingle.java 94.91% <0%> (-5.09%) 3% <0%> (ø)
...ernal/operators/maybe/MaybeTakeUntilPublisher.java 96% <0%> (-4%) 2% <0%> (ø)
...al/operators/flowable/FlowableSamplePublisher.java 93.61% <0%> (-3.2%) 3% <0%> (ø)
...x/internal/operators/maybe/MaybeSwitchIfEmpty.java 97.22% <0%> (-2.78%) 2% <0%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a83b3...34c4858. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants