Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: update some marbles of Observable #5351

Merged
merged 1 commit into from
May 18, 2017

Conversation

akarnokd
Copy link
Member

Update/fix to a couple of marble diagrams in Observable:

@akarnokd akarnokd added this to the 2.0 backlog milestone May 17, 2017
@codecov
Copy link

codecov bot commented May 17, 2017

Codecov Report

Merging #5351 into 2.x will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5351      +/-   ##
============================================
+ Coverage     96.14%   96.18%   +0.04%     
+ Complexity     5781     5778       -3     
============================================
  Files           630      630              
  Lines         41162    41162              
  Branches       5721     5721              
============================================
+ Hits          39576    39593      +17     
+ Misses          621      612       -9     
+ Partials        965      957       -8
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 506 <0> (ø) ⬇️
...al/operators/observable/ObservableSampleTimed.java 91.66% <0%> (-6.67%) 3% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 85.93% <0%> (-5.73%) 57% <0%> (+1%)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <0%> (-4.62%) 27% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 58.86% <0%> (-4.26%) 31% <0%> (-3%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...vex/internal/operators/flowable/FlowableTimer.java 92.85% <0%> (-3.58%) 2% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 94.91% <0%> (-3.39%) 10% <0%> (-1%)
...x/internal/operators/maybe/MaybeSwitchIfEmpty.java 97.22% <0%> (-2.78%) 2% <0%> (ø)
...java/io/reactivex/subjects/CompletableSubject.java 94.8% <0%> (-2.6%) 35% <0%> (-1%)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c7957...e5f69e7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant