-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: add Single.unsubscribeOn() #5302
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
src/main/java/io/reactivex/internal/operators/single/SingleUnsubscribeOn.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex.internal.operators.single; | ||
|
||
import java.util.concurrent.atomic.AtomicReference; | ||
|
||
import io.reactivex.*; | ||
import io.reactivex.disposables.Disposable; | ||
import io.reactivex.internal.disposables.DisposableHelper; | ||
|
||
/** | ||
* Makes sure a dispose() call from downstream happens on the specified scheduler. | ||
* | ||
* @param <T> the value type | ||
*/ | ||
public final class SingleUnsubscribeOn<T> extends Single<T> { | ||
|
||
final SingleSource<T> source; | ||
|
||
final Scheduler scheduler; | ||
|
||
public SingleUnsubscribeOn(SingleSource<T> source, Scheduler scheduler) { | ||
this.source = source; | ||
this.scheduler = scheduler; | ||
} | ||
|
||
@Override | ||
protected void subscribeActual(SingleObserver<? super T> observer) { | ||
source.subscribe(new UnsubscribeOnSingleObserver<T>(observer, scheduler)); | ||
} | ||
|
||
static final class UnsubscribeOnSingleObserver<T> extends AtomicReference<Disposable> | ||
implements SingleObserver<T>, Disposable, Runnable { | ||
|
||
private static final long serialVersionUID = 3256698449646456986L; | ||
|
||
final SingleObserver<? super T> actual; | ||
|
||
final Scheduler scheduler; | ||
|
||
Disposable ds; | ||
|
||
UnsubscribeOnSingleObserver(SingleObserver<? super T> actual, Scheduler scheduler) { | ||
this.actual = actual; | ||
this.scheduler = scheduler; | ||
} | ||
|
||
@Override | ||
public void dispose() { | ||
Disposable d = getAndSet(DisposableHelper.DISPOSED); | ||
if (d != DisposableHelper.DISPOSED) { | ||
this.ds = d; | ||
scheduler.scheduleDirect(this); | ||
} | ||
} | ||
|
||
@Override | ||
public void run() { | ||
ds.dispose(); | ||
} | ||
|
||
@Override | ||
public boolean isDisposed() { | ||
return DisposableHelper.isDisposed(get()); | ||
} | ||
|
||
@Override | ||
public void onSubscribe(Disposable d) { | ||
if (DisposableHelper.setOnce(this, d)) { | ||
actual.onSubscribe(this); | ||
} | ||
} | ||
|
||
@Override | ||
public void onSuccess(T value) { | ||
actual.onSuccess(value); | ||
} | ||
|
||
@Override | ||
public void onError(Throwable e) { | ||
actual.onError(e); | ||
} | ||
} | ||
} |
130 changes: 130 additions & 0 deletions
130
src/test/java/io/reactivex/internal/operators/single/SingleUnsubscribeOnTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex.internal.operators.single; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
import java.util.concurrent.*; | ||
|
||
import org.junit.Test; | ||
|
||
import io.reactivex.*; | ||
import io.reactivex.disposables.Disposable; | ||
import io.reactivex.exceptions.TestException; | ||
import io.reactivex.functions.*; | ||
import io.reactivex.processors.PublishProcessor; | ||
import io.reactivex.schedulers.Schedulers; | ||
|
||
public class SingleUnsubscribeOnTest { | ||
|
||
@Test | ||
public void normal() throws Exception { | ||
PublishProcessor<Integer> pp = PublishProcessor.create(); | ||
|
||
final String[] name = { null }; | ||
|
||
final CountDownLatch cdl = new CountDownLatch(1); | ||
|
||
pp.doOnCancel(new Action() { | ||
@Override | ||
public void run() throws Exception { | ||
name[0] = Thread.currentThread().getName(); | ||
cdl.countDown(); | ||
} | ||
}) | ||
.single(-99) | ||
.unsubscribeOn(Schedulers.single()) | ||
.test(true) | ||
; | ||
|
||
assertTrue(cdl.await(5, TimeUnit.SECONDS)); | ||
|
||
int times = 10; | ||
|
||
while (times-- > 0 && pp.hasSubscribers()) { | ||
Thread.sleep(100); | ||
} | ||
|
||
assertFalse(pp.hasSubscribers()); | ||
|
||
assertNotEquals(Thread.currentThread().getName(), name[0]); | ||
} | ||
|
||
@Test | ||
public void just() { | ||
Single.just(1) | ||
.unsubscribeOn(Schedulers.single()) | ||
.test() | ||
.assertResult(1); | ||
} | ||
|
||
@Test | ||
public void error() { | ||
Single.<Integer>error(new TestException()) | ||
.unsubscribeOn(Schedulers.single()) | ||
.test() | ||
.assertFailure(TestException.class); | ||
} | ||
|
||
@Test | ||
public void dispose() { | ||
TestHelper.checkDisposed(Single.just(1) | ||
.unsubscribeOn(Schedulers.single())); | ||
} | ||
|
||
@Test | ||
public void doubleOnSubscribe() { | ||
TestHelper.checkDoubleOnSubscribeSingle(new Function<Single<Object>, SingleSource<Object>>() { | ||
@Override | ||
public SingleSource<Object> apply(Single<Object> v) throws Exception { | ||
return v.unsubscribeOn(Schedulers.single()); | ||
} | ||
}); | ||
} | ||
|
||
@Test | ||
public void disposeRace() { | ||
for (int i = 0; i < 500; i++) { | ||
PublishProcessor<Integer> pp = PublishProcessor.create(); | ||
|
||
final Disposable[] ds = { null }; | ||
pp.single(-99).unsubscribeOn(Schedulers.computation()) | ||
.subscribe(new SingleObserver<Integer>() { | ||
@Override | ||
public void onSubscribe(Disposable d) { | ||
ds[0] = d; | ||
} | ||
|
||
@Override | ||
public void onSuccess(Integer value) { | ||
|
||
} | ||
|
||
@Override | ||
public void onError(Throwable e) { | ||
|
||
} | ||
}); | ||
|
||
Runnable r = new Runnable() { | ||
@Override | ||
public void run() { | ||
ds[0].dispose(); | ||
} | ||
}; | ||
|
||
TestHelper.race(r, r, Schedulers.single()); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this landed on the wrong method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.