2.x: add ParallelTransformer interface, params-validation #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5197 +/- ##
============================================
- Coverage 95.96% 95.89% -0.07%
+ Complexity 5683 5682 -1
============================================
Files 621 621
Lines 40611 40611
Branches 5632 5632
============================================
- Hits 38973 38945 -28
- Misses 657 672 +15
- Partials 981 994 +13
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Mar 20, 2017
| public final <U> ParallelFlowable<U> compose(Function<? super ParallelFlowable<T>, ParallelFlowable<U>> composer) { | ||
| return RxJavaPlugins.onAssembly(to(composer)); | ||
| public final <U> ParallelFlowable<U> compose(@NonNull ParallelTransformer<T, U> composer) { | ||
| return RxJavaPlugins.onAssembly(composer.apply(this)); |
There was a problem hiding this comment.
Missing check here for composer being null?
| @@ -611,7 +611,7 @@ protected final boolean validate(Subscriber<?>[] subscribers) { | |||
| * @return the value returned by the converter function | |||
| */ | |||
| @CheckReturnValue | |||
| public final <U> U to(Function<? super ParallelFlowable<T>, U> converter) { | |||
| public final <U> U to(@NonNull Function<? super ParallelFlowable<T>, U> converter) { | |||
| try { | |||
| return converter.apply(this); | |||
There was a problem hiding this comment.
Missing check here for converter being null
There was a problem hiding this comment.
Dereference will throw NPE automatically.
There was a problem hiding this comment.
I'd still check it in order to be consistent and for the better error message knowing what exactly is null.
There was a problem hiding this comment.
Updated this and all other methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ParallelTransformerinterface to match the otherXTransformerinterfaces, adds@NonNullannotations to theParallelFlowableoperators and adds theParallelFlowableclass to the parameter validator test set.