Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: reflection-based parameter validator & fixes #5187

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

akarnokd
Copy link
Member

This PR adds a reflection-based parameter validator to check the base reactive classes for proper parameter validation: null checks and argument ranges. The problems detected are fixed as well.

@akarnokd akarnokd added this to the 2.0 backlog milestone Mar 15, 2017
@codecov
Copy link

codecov bot commented Mar 15, 2017

Codecov Report

Merging #5187 into 2.x will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                2.x    #5187      +/-   ##
============================================
+ Coverage     95.98%   96.04%   +0.05%     
- Complexity     5665     5673       +8     
============================================
  Files           621      621              
  Lines         40340    40581     +241     
  Branches       5616     5620       +4     
============================================
+ Hits          38722    38975     +253     
- Misses          638      641       +3     
+ Partials        980      965      -15
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 99.32% <100%> (+0.02%) 131 <12> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 97.22% <100%> (+0.25%) 10 <1> (ø)
src/main/java/io/reactivex/Flowable.java 100% <100%> (ø) 522 <19> (ø)
src/main/java/io/reactivex/Observable.java 100% <100%> (ø) 506 <46> (ø)
src/main/java/io/reactivex/Maybe.java 100% <100%> (ø) 168 <10> (+1)
src/main/java/io/reactivex/Completable.java 100% <100%> (ø) 112 <1> (ø)
...rators/observable/ObservableBlockingSubscribe.java 96.96% <100%> (+0.3%) 9 <1> (ø)
.../java/io/reactivex/subscribers/TestSubscriber.java 99.27% <100%> (+0.01%) 57 <0> (+1)
...vex/internal/operators/single/SingleTakeUntil.java 86.88% <0%> (-6.56%) 2% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <0%> (-4.62%) 27% <0%> (-1%)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d03fa9...bd35fc7. Read the comment docs.

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@akarnokd
Copy link
Member Author

Thanks @vanniktech ! I'm merging this because there are a couple of inbound API changes from other contributors and having this in place avoids conflicts.

@akarnokd akarnokd merged commit b58642b into ReactiveX:2.x Mar 15, 2017
@akarnokd akarnokd deleted the ParamValidationChecker branch March 15, 2017 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants