-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes all anonymous inner classes #5177
Removes all anonymous inner classes #5177
Conversation
@SleimanJneidi what's the motivation behind making this change? |
@naturalwarren to improve stack-traces and to reduce the footprint. |
Makes sense, thanks for filling me in! |
Codecov Report
@@ Coverage Diff @@
## 2.x #5177 +/- ##
===========================================
- Coverage 95.96% 95.87% -0.1%
+ Complexity 5665 5646 -19
===========================================
Files 621 621
Lines 40247 40320 +73
Branches 5610 5610
===========================================
+ Hits 38624 38655 +31
- Misses 643 670 +27
- Partials 980 995 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This is a what left to complete this one :
Removes all AICs
Issue #5150