Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes all anonymous inner classes #5177

Merged

Conversation

SleimanJneidi
Copy link
Contributor

@SleimanJneidi SleimanJneidi commented Mar 12, 2017

This is a what left to complete this one :

  • Removes all AICs

  • Issue #5150

@naturalwarren
Copy link

@SleimanJneidi what's the motivation behind making this change?

@SleimanJneidi
Copy link
Contributor Author

@naturalwarren to improve stack-traces and to reduce the footprint.

@naturalwarren
Copy link

@naturalwarren to improve stack-traces and to reduce the footprint.

Makes sense, thanks for filling me in!

@codecov
Copy link

codecov bot commented Mar 12, 2017

Codecov Report

Merging #5177 into 2.x will decrease coverage by 0.09%.
The diff coverage is 96.03%.

@@             Coverage Diff             @@
##                2.x    #5177     +/-   ##
===========================================
- Coverage     95.96%   95.87%   -0.1%     
+ Complexity     5665     5646     -19     
===========================================
  Files           621      621             
  Lines         40247    40320     +73     
  Branches       5610     5610             
===========================================
+ Hits          38624    38655     +31     
- Misses          643      670     +27     
- Partials        980      995     +15
Impacted Files Coverage Δ Complexity Δ
...tivex/internal/schedulers/TrampolineScheduler.java 94.73% <100%> (+0.29%) 6 <0> (ø)
.../main/java/io/reactivex/schedulers/Schedulers.java 100% <100%> (ø) 10 <1> (ø)
...activex/internal/schedulers/ExecutorScheduler.java 96.47% <100%> (+0.18%) 9 <0> (ø)
.../reactivex/internal/subscriptions/FullArbiter.java 98.03% <100%> (+0.01%) 29 <1> (ø)
...va/io/reactivex/internal/util/ExceptionHelper.java 100% <100%> (ø) 15 <1> (ø)
src/main/java/io/reactivex/Scheduler.java 100% <100%> (ø) 11 <0> (ø)
...in/java/io/reactivex/schedulers/TestScheduler.java 100% <100%> (ø) 11 <0> (ø)
.../io/reactivex/internal/functions/ObjectHelper.java 100% <100%> (ø) 21 <1> (ø)
...ivex/internal/schedulers/SchedulerPoolFactory.java 76.19% <81.81%> (+0.58%) 7 <0> (ø)
...o/reactivex/internal/schedulers/SchedulerWhen.java 79.06% <87.5%> (+3.06%) 4 <1> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f77fa...ffecd5b. Read the comment docs.

@akarnokd akarnokd added this to the 2.0 backlog milestone Mar 12, 2017
Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants