Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix private field access, few generics problems #5176

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

akarnokd
Copy link
Member

This PR fixes some private field accessor problems introduced by #5174 as well as a couple of generics warnings.

Note that in IntelliJ, there is a J2ME inspection for private access checks between parent and inner classes.

@akarnokd akarnokd added this to the 2.1 milestone Mar 11, 2017
@codecov
Copy link

codecov bot commented Mar 11, 2017

Codecov Report

Merging #5176 into 2.x will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                2.x    #5176      +/-   ##
============================================
+ Coverage     95.95%   95.96%   +0.01%     
+ Complexity     5660     5658       -2     
============================================
  Files           621      621              
  Lines         40247    40247              
  Branches       5610     5610              
============================================
+ Hits          38617    38625       +8     
  Misses          648      648              
+ Partials        982      974       -8
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/completable/CompletableDelay.java 100% <ø> (ø) 2 <0> (ø)
...s/observable/ObservableDelaySubscriptionOther.java 100% <ø> (ø) 2 <0> (ø)
...ators/flowable/FlowableDelaySubscriptionOther.java 100% <ø> (ø) 2 <0> (ø)
...activex/internal/operators/single/SingleDelay.java 100% <ø> (ø) 2 <0> (ø)
...l/operators/completable/CompletableResumeNext.java 100% <ø> (ø) 2 <0> (ø)
...rnal/operators/completable/CompletableTimeout.java 98% <ø> (ø) 2 <0> (ø)
...tivex/internal/operators/single/SingleTimeout.java 96% <ø> (ø) 2 <0> (ø)
...nternal/operators/completable/CompletablePeek.java 96.87% <100%> (ø) 2 <0> (ø)
...nternal/operators/observable/ObservableReplay.java 97.18% <100%> (-0.57%) 18 <0> (ø)
...ex/internal/operators/flowable/FlowableReplay.java 91.04% <100%> (ø) 17 <0> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c22f96...152b048. Read the comment docs.

@akarnokd akarnokd merged commit 67f77fa into ReactiveX:2.x Mar 11, 2017
@akarnokd akarnokd deleted the Cleanup170311 branch March 11, 2017 22:40
@vanniktech
Copy link
Collaborator

PMD also has a check for those synthetic methods since 5.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants