Improve compose() generics #4972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side-note: gets even better on Java 8, which removes the need for a type argument at all in those examples!
|
ZacSweers
commented
Jan 8, 2017
| @@ -83,7 +82,7 @@ public void maybeTransformerThrows() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void completabeTransformerThrows() { | |||
| public void completableTransformerThrows() { | |||
There was a problem hiding this comment.
Took the opportunity to fix a typo in this method name
Current coverage is 95.63% (diff: 100%)@@ 2.x #4972 diff @@
==========================================
Files 591 591
Lines 37959 37959
Methods 0 0
Messages 0 0
Branches 5756 5756
==========================================
+ Hits 36264 36302 +38
+ Misses 721 698 -23
+ Partials 974 959 -15
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4950
I tested and built with the added tests on Java 6, 7, and 8. Not sure if you want to keep them in before merging since they're not really functional in nature, just there to make sure they compile.