2.x: fix withLatestFrom null checks, lifecycle #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.58% (diff: 100%)@@ 2.x #4970 diff @@
==========================================
Files 591 591
Lines 37959 37956 -3
Methods 0 0
Messages 0 0
Branches 5756 5753 -3
==========================================
+ Hits 36264 36282 +18
+ Misses 721 712 -9
+ Partials 974 962 -12
|
JakeWharton
approved these changes
Jan 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the lack of null check on the result of the
combinerfunction as well as fixes the lifecycle of theFlowableWithLatestFromto avoid races with theonSubscribe.