2.x: fix LambdaObserver calling dispose when terminating #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.68% (diff: 100%)@@ 2.x #4957 diff @@
==========================================
Files 587 587
Lines 37551 37551
Methods 0 0
Messages 0 0
Branches 5655 5655
==========================================
- Hits 35950 35929 -21
- Misses 676 685 +9
- Partials 925 937 +12
|
JakeWharton
approved these changes
Jan 4, 2017
ZacSweers
added a commit
to uber/AutoDispose
that referenced
this pull request
Feb 16, 2017
Matches ReactiveX/RxJava#4957, which we were doing wrong. Note the lifecycle disposable is not lazily set because that's internally managed and non-terminating.
ZacSweers
added a commit
to uber/AutoDispose
that referenced
this pull request
Feb 26, 2017
Matches ReactiveX/RxJava#4957, which we were doing wrong. Note the lifecycle disposable is not lazily set because that's internally managed and non-terminating.
Matt-Hallcok
added a commit
to Matt-Hallcok/AutoDispose
that referenced
this pull request
Dec 28, 2019
Matches ReactiveX/RxJava#4957, which we were doing wrong. Note the lifecycle disposable is not lazily set because that's internally managed and non-terminating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
LambdaObserverto not dispose the upstream when it receives a terminal event. TheLambdaSubscriberhas been previoulsy updated but apparently not synced.Reported in #4956.
This PR fixes 2 unit test methods of
Flowable.ignoreElements()as they were not actually testing the operator (discovered when theObservable.ignoreElements()initially failed after the patch toLambdaObserver).