2.x: fix & update Observable.repeatWhen and retryWhen (again) #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the travis-ci/push still shows up. |
akarnokd
force-pushed
the
ObservableRepeatWhenFix2
branch
from
9f8eaa0
to
c7b4ccb
Compare
Current coverage is 95.64% (diff: 98.43%)@@ 2.x #4911 diff @@
==========================================
Files 586 586
Lines 37410 37446 +36
Methods 0 0
Messages 0 0
Branches 5628 5625 -3
==========================================
+ Hits 35791 35814 +23
- Misses 671 695 +24
+ Partials 948 937 -11
|
JakeWharton
approved these changes
Dec 9, 2016
akarnokd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
Observable.repeatWhennot completing properly if the handler completes. In addition, theObservableRedohas been split toObservableRetryWhenandObservableRepeatWhenjust like theirFlowablecounterpart and are now they use a less convoluted algorithm.Related: #4909