Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: FlowableScan - prevent multiple terminal emissions #4901

Merged
merged 1 commit into from
Dec 3, 2016

Conversation

davidmoten
Copy link
Collaborator

For scan without seed this PR

  • prevents multiple terminal events being emitted when the scan function throws
  • prevents processing of a later onNext if the previous onNext processing resulted in an error emission
  • ensures post terminal errors are reported to RxJavaPlugins error handler

For scan with seed (forgot this one in the last PR)

  • ensures post terminal errors are reported to RxJavaPlugins error handler

@akarnokd akarnokd added this to the 2.0 backlog milestone Dec 3, 2016
@codecov-io
Copy link

codecov-io commented Dec 3, 2016

Current coverage is 95.68% (diff: 100%)

Merging #4901 into 2.x will increase coverage by 0.01%

@@                2.x      #4901   diff @@
==========================================
  Files           586        586          
  Lines         37389      37399    +10   
  Methods           0          0          
  Messages          0          0          
  Branches       5621       5624     +3   
==========================================
+ Hits          35769      35785    +16   
+ Misses          678        677     -1   
+ Partials        942        937     -5   

Powered by Codecov. Last update 75e9bfa...f3c4c27

@akarnokd akarnokd merged commit a39fa89 into ReactiveX:2.x Dec 3, 2016
@davidmoten davidmoten changed the title FlowableScan - prevent multiple terminal emissions 2.x: FlowableScan - prevent multiple terminal emissions Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants