2.x: FlowableScanSeed - prevent multiple terminal events #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.60% (diff: 100%)@@ 2.x #4899 diff @@
==========================================
Files 586 586
Lines 37381 37389 +8
Methods 0 0
Messages 0 0
Branches 5618 5621 +3
==========================================
- Hits 35812 35746 -66
- Misses 653 691 +38
- Partials 916 952 +36
|
akarnokd
requested changes
Dec 3, 2016
| @@ -51,6 +51,8 @@ protected void subscribeActual(Subscriber<? super R> s) { | |||
| private static final long serialVersionUID = -1776795561228106469L; | |||
|
|
|||
| final BiFunction<R, ? super T, R> accumulator; | |||
|
|
|||
| boolean done = false; | |||
There was a problem hiding this comment.
No need to set a default value.
davidmoten
force-pushed
the
fix-FlowableScanSeed
branch
from
9918a4f
to
e55459b
Compare
|
updated PR with |
akarnokd
approved these changes
Dec 3, 2016
davidmoten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
onNextif the previousonNextprocessing resulted in an error emissionFlowableScanSeed