Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix Observable.repeatWhen & retryWhen not disposing the inner #4783

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

akarnokd
Copy link
Member

The Observer that is subscribing to the Observable returned by the handler function was not properly linked to the disposing of the end Observer. This PR fixes it by making that Observer do async Disposable management and make sure the end Observer receives a disposable list with both the main and the handler Disposables.

The Flowable versions worked properly but added unit tests to them regardless.

Reported in #4782.

@akarnokd akarnokd added the Bug label Oct 30, 2016
@akarnokd akarnokd added this to the 2.1 milestone Oct 30, 2016
@codecov-io
Copy link

codecov-io commented Oct 31, 2016

Current coverage is 95.72% (diff: 91.66%)

Merging #4783 into 2.x will decrease coverage by 0.14%

@@                2.x      #4783   diff @@
==========================================
  Files           570        570          
  Lines         36713      36717     +4   
  Methods           0          0          
  Messages          0          0          
  Branches       5555       5554     -1   
==========================================
- Hits          35200      35149    -51   
- Misses          617        646    +29   
- Partials        896        922    +26   

Powered by Codecov. Last update 3300d19...02aa31c

@akarnokd akarnokd merged commit ff282b9 into ReactiveX:2.x Oct 31, 2016
@akarnokd akarnokd deleted the ObservableRedoFix branch March 24, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants