2.x: coverage, fixes, cleanup 10/15-1 #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.19% (diff: 95.52%)@@ 2.x #4708 diff @@
==========================================
Files 567 568 +1
Lines 37154 37061 -93
Methods 0 0
Messages 0 0
Branches 5680 5648 -32
==========================================
+ Hits 32032 32316 +284
+ Misses 3360 3042 -318
+ Partials 1762 1703 -59
|
JakeWharton
approved these changes
Oct 15, 2016
| @@ -185,21 +183,14 @@ public void onNext(T t) { | |||
| U b; | |||
|
|
|||
| try { | |||
| b = bufferSupplier.call(); | |||
| b = ObjectHelper.requireNonNull(bufferSupplier.call(), "onNext called with null. Null values are generally not allowed in 2.x operators and sources."); | |||
There was a problem hiding this comment.
"onNext" --> "bufferSupplier"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observableoperatorspublish(Function)latecommer behaviorbufferSizeoverloads ofpublishas there is no need to buffer anything for anObservableObservable.publish