2.x: Clean up null usages by using ObjectHelper.requireNonNull #4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.16% (diff: 100%)@@ 2.x #4699 diff @@
==========================================
Files 567 567
Lines 37651 37319 -332
Methods 0 0
Messages 0 0
Branches 5795 5703 -92
==========================================
- Hits 31604 31408 -196
+ Misses 4087 3977 -110
+ Partials 1960 1934 -26
|
akarnokd
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an if statement to check for
null,ObjectHelper.requireNonNullwill be used now. This reduces a lot of duplicated code. Also I found a few places (mostly zip operators) where the wrong Throwable was being onError'd.In addition for one of the Completable operators the CompositeException call has been fixed. In addition I found another one that was wrong.