Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: coverage and cleanup 10/12-1 #4696

Merged
merged 1 commit into from
Oct 12, 2016
Merged

2.x: coverage and cleanup 10/12-1 #4696

merged 1 commit into from
Oct 12, 2016

Conversation

akarnokd
Copy link
Member

  • Add coverage to remaining Completable operators
  • Fix inner Throwable order for CompletablePeek
  • Compact/rewrite a few operators

@akarnokd akarnokd added this to the 2.0 RC5 milestone Oct 12, 2016
@codecov-io
Copy link

codecov-io commented Oct 12, 2016 •
edited
Loading

Current coverage is 83.86% (diff: 97.46%)

Merging #4696 into 2.x will increase coverage by 0.41%

@@                2.x      #4696   diff @@
==========================================
  Files           567        567          
  Lines         37618      37651    +33   
  Methods           0          0          
  Messages          0          0          
  Branches       5790       5795     +5   
==========================================
+ Hits          31393      31577   +184   
+ Misses         4233       4116   -117   
+ Partials       1992       1958    -34

Powered by Codecov. Last update 35c2951...b3382a2

@vanniktech
Copy link
Collaborator

@akarnokd you missed the wrong CompositeException constructor call in CompletableResumeNext

@akarnokd akarnokd merged commit e71d371 into ReactiveX:2.x Oct 12, 2016
@akarnokd akarnokd deleted the Coverage10_12_1 branch October 12, 2016 15:50
@akarnokd
Copy link
Member Author

@vanniktech yeah. Would you like to do a PR?

@vanniktech
Copy link
Collaborator

I'll include that in one that I was planning to push out anyways today which is a big bigger. ~60 files

@akarnokd
Copy link
Member Author

What are you changing in 60 files?

@vanniktech
Copy link
Collaborator

Null cleanups

@akarnokd akarnokd mentioned this pull request Oct 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
Cleanup Coverage
Projects
None yet
Milestone
2.0 RC5
Development

Successfully merging this pull request may close these issues.
4 participants
@akarnokd @codecov-io @vanniktech @JakeWharton