2.x: CompositeException fix order of Exceptions #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 83.47% (diff: 30.76%)@@ 2.x #4695 diff @@
==========================================
Files 567 567
Lines 37618 37618
Methods 0 0
Messages 0 0
Branches 5790 5790
==========================================
+ Hits 31399 31400 +1
- Misses 4218 4219 +1
+ Partials 2001 1999 -2
|
|
I'm working on completable. Please skip those classes. |
|
Alright did that. |
akarnokd
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at #4692 I found a few more exceptions which were passed in the wrong order to CompositeException.