Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: flatMap{Completable, Maybe, Single} operators #4667

Merged
merged 4 commits into from
Oct 5, 2016

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 4, 2016

This PR adds Observable.flatMapCompletable(Function<T, CompletableSource>) and Flowable.flatMapCompletable(Function<T, CompletableSource>), both resulting in Completable (+ support for fusing back to the original type).

Edit

Added flatMapMaybe and flatMapSingle variants to both Flowable and Observable.

@akarnokd akarnokd added this to the 2.0 RC4 milestone Oct 4, 2016
@akarnokd
Copy link
Member Author

akarnokd commented Oct 4, 2016

The build gets killed at the jacocoTestResults:

:jacocoTestReportgradle/buildViaTravis.sh: line 16:  2970 Killed                  ./gradlew -Prelease.useLastTag=true build

I've rerun it a couple of times. Maybe Travis is overloaded at the moment.

@codecov-io
Copy link

codecov-io commented Oct 4, 2016

Current coverage is 82.13% (diff: 72.71%)

Merging #4667 into 2.x will decrease coverage by 0.21%

@@                2.x      #4667   diff @@
==========================================
  Files           557        565     +8   
  Lines         36402      37399   +997   
  Methods           0          0          
  Messages          0          0          
  Branches       5568       5746   +178   
==========================================
+ Hits          29974      30716   +742   
- Misses         4437       4607   +170   
- Partials       1991       2076    +85   

Powered by Codecov. Last update 23a77e8...56b160a

@akarnokd akarnokd changed the title 2.x: flatMapCompletable operator 2.x: flatMap{Completable, Maybe, Single} operators (part 1) Oct 4, 2016
@akarnokd
Copy link
Member Author

akarnokd commented Oct 4, 2016

Updated with the remaining operators.

Copy link
Contributor

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brain melted slightly reviewing these operators, but looks good.

@akarnokd akarnokd changed the title 2.x: flatMap{Completable, Maybe, Single} operators (part 1) 2.x: flatMap{Completable, Maybe, Single} operators Oct 5, 2016
@akarnokd akarnokd merged commit 88ff1f6 into ReactiveX:2.x Oct 5, 2016
@akarnokd akarnokd deleted the FlatMap0or1 branch October 5, 2016 08:11
@vanniktech
Copy link
Collaborator

Thanks a lot for taking this one over @akarnokd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants