Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Maybe and Single to use their Transformers in compose() #4651

Merged
merged 2 commits into from
Oct 1, 2016

Conversation

ZacSweers
Copy link
Contributor

Resolves #4650

@@ -1967,13 +1967,12 @@ public final T blockingGet(T defaultValue) {
* </dl>
*
* @param <R> the value type of the Maybe returned by the transformer function
* @param transformer
* implements the function that transforms the source Maybe
* @param transformer the transformer function, not null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I just borrowed from the Completable.compose() doc wording here

@ZacSweers
Copy link
Contributor Author

Whoops forgot to update the tests, will update in a sec

@akarnokd
Copy link
Member

akarnokd commented Oct 1, 2016

IntelliJ user I presume?

@akarnokd akarnokd added this to the 2.0 RC4 milestone Oct 1, 2016
@ZacSweers
Copy link
Contributor Author

ZacSweers commented Oct 1, 2016

Indeed... Does (I presume 😉) eclipse do something to protect against this?

@akarnokd
Copy link
Member

akarnokd commented Oct 1, 2016

Eclipse has an error view which doesn't obscure the project structure, plus when one shows the breadcrumbs, they get error icons indicating there's still something wrong (also the project tree gets error icons) so it is much harder to miss these kinds of errors.

@codecov-io
Copy link

Current coverage is 77.87% (diff: 100%)

Merging #4651 into 2.x will decrease coverage by 0.04%

@@                2.x      #4651   diff @@
==========================================
  Files           559        559          
  Lines         36654      36654          
  Methods           0          0          
  Messages          0          0          
  Branches       5625       5625          
==========================================
- Hits          28560      28543    -17   
- Misses         6065       6078    +13   
- Partials       2029       2033     +4   

Powered by Codecov. Last update 9047a3c...fccdfca

@akarnokd akarnokd merged commit 5ad1c04 into ReactiveX:2.x Oct 1, 2016
@ZacSweers
Copy link
Contributor Author

Interesting, I'll have to check that out!

@ZacSweers ZacSweers deleted the z/transformers branch October 1, 2016 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants