Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add Completable.fromRunnable() #4629

Merged
merged 1 commit into from
Sep 29, 2016
Merged

2.x: Add Completable.fromRunnable() #4629

merged 1 commit into from
Sep 29, 2016

Conversation

pt2121
Copy link

@pt2121 pt2121 commented Sep 29, 2016

addresses #4628

There's Maybe.fromRunnable but Completable is missing this method.

@codecov-io
Copy link

codecov-io commented Sep 29, 2016

Current coverage is 78.13% (diff: 88.23%)

Merging #4629 into 2.x will increase coverage by 0.01%

@@                2.x      #4629   diff @@
==========================================
  Files           557        558     +1   
  Lines         36278      36295    +17   
  Methods           0          0          
  Messages          0          0          
  Branches       5563       5565     +2   
==========================================
+ Hits          28341      28359    +18   
+ Misses         5926       5916    -10   
- Partials       2011       2020     +9   

Powered by Codecov. Last update 64f335c...10f2410

@JakeWharton
Copy link
Contributor

Thanks!

@akarnokd akarnokd merged commit a30fb4d into ReactiveX:2.x Sep 29, 2016
@akarnokd
Copy link
Member

Thanks!

@akarnokd akarnokd added this to the 2.0 RC4 milestone Sep 29, 2016
@pt2121 pt2121 deleted the pt/comletetable-from-runnable branch September 29, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants