2.x: TestSubscriber & TestObserver add assertValue(Predicate) #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
requested changes
Sep 26, 2016
|
|
||
| for (T value : values) { | ||
| try { | ||
| if (valuePredicate.test(value)) { |
There was a problem hiding this comment.
This is unnecessary, just test values.get(0) and then report if s > 1 besides.
There was a problem hiding this comment.
Yeah thought of that too I just took the same implementation as assertError(predicate). I'll change it there too, ok?
There was a problem hiding this comment.
Any reason why?
There was a problem hiding this comment.
Because the first error may come from the lack of onSubscribe call or some other unexpected exception. Knowing that the exception is there but not the only one is different from expecting exactly 1 element but then getting n.
There was a problem hiding this comment.
Oh that makes sense. Thanks David for the explanation
akarnokd
approved these changes
Sep 26, 2016
akarnokd
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.