-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Add missing Resource Observer for Maybe, Completable & Single and adjust some Javadoc #4518
2.x: Add missing Resource Observer for Maybe, Completable & Single and adjust some Javadoc #4518
Conversation
…d adjust some Javadoc
@@ -62,10 +65,6 @@ public void onComplete() { | |||
|
|||
dispose(); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was for coverage on the protected cancel method.
Current coverage is 78.60% (diff: 100%)@@ 2.x #4518 diff @@
==========================================
Files 507 510 +3
Lines 34386 34424 +38
Methods 0 0
Messages 0 0
Branches 5395 5401 +6
==========================================
+ Hits 27003 27059 +56
+ Misses 5411 5401 -10
+ Partials 1972 1964 -8
|
It might be worth considering removing the protected |
So should I remove the |
@JakeWharton your opinion on the removal? |
I'm supportive of removing |
👍 |
Fixes #4517