2.x: fix Single.using, add unit tests and coverage #4516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've forgotten to create a branch so the first part of todays coverage work landed in 2.x direct
SpscArrayQueue
SpscLinkedArrayQueue.offer()
andMpscLinkedQueue.offer()
ResourceObserver
not callingonStart
AppendOnlyLinkedArrayList
, updatedSerializedObserver
andSerializedSubscriber
to use it directly instead of the former indirectionTestObserver.isDisposed
now reports true if terminal events were received (2.x Should observer be disposed after the source observable has finished emitting items? #4514)ResourceSubscriber
to useSubscriptionHelper
's deferred Subscription/requesting managementDisposableXObserver
sSerializedObserver
andSerializedSubscriber
now have proper unit tests eachThis current PR fixes
Single.using
not properly managing the resource and adds unit tests to verify the behavior along with a few extra coverage improvements.