Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix Single.using, add unit tests and coverage #4516

Merged
merged 1 commit into from
Sep 8, 2016

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 8, 2016

I've forgotten to create a branch so the first part of todays coverage work landed in 2.x direct

  • removed unused methods from various classes
  • compacted SpscArrayQueue
  • added null checks to SpscLinkedArrayQueue.offer() and MpscLinkedQueue.offer()
  • fixed ResourceObserver not calling onStart
  • Added direct NotificationLite-emission methods to AppendOnlyLinkedArrayList, updated SerializedObserver and SerializedSubscriber to use it directly instead of the former indirection
  • TestObserver.isDisposed now reports true if terminal events were received (2.x Should observer be disposed after the source observable has finished emitting items? #4514)
  • ResourceSubscriber to use SubscriptionHelper's deferred Subscription/requesting management
  • added unit tests to cover DisposableXObservers
  • SerializedObserver and SerializedSubscriber now have proper unit tests each

This current PR fixes Single.using not properly managing the resource and adds unit tests to verify the behavior along with a few extra coverage improvements.

@JakeWharton
Copy link
Contributor

👍

@codecov-io
Copy link

codecov-io commented Sep 8, 2016

Current coverage is 78.64% (diff: 96.92%)

Merging #4516 into 2.x will increase coverage by 0.36%

@@                2.x      #4516   diff @@
==========================================
  Files           507        507          
  Lines         34371      34386    +15   
  Methods           0          0          
  Messages          0          0          
  Branches       5391       5395     +4   
==========================================
+ Hits          26904      27042   +138   
+ Misses         5480       5374   -106   
+ Partials       1987       1970    -17   

Powered by Codecov. Last update 1145819...0ee4580

@akarnokd akarnokd merged commit 4f878d5 into ReactiveX:2.x Sep 8, 2016
@akarnokd akarnokd deleted the Coverage908_2 branch September 8, 2016 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants