1.x: Single.using() #3752
Merged
1.x: Single.using() #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| @Test | ||
| public void withSubscribingTwice() { | ||
| performTestUsingWithSubscribingTwice(false); |
There was a problem hiding this comment.
nit: probably worth to create constants with meaningful name to use them instead of true/false, something like:
@Test
public void withSubscribingTwice() {
performTestUsingWithSubscribingTwice(DONT_DISPOSE_EAGERLY);
}There was a problem hiding this comment.
Maybe next time. I'm already removing test prefixes for you.
|
👍 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the factory method
using()+1 overload toSingleas requested in #3732.For convenience, I've also added
Single.subscribe(Observer).