scan should pass upstream a request of Long.MAX_VALUE #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2.x is not affected because it does a full queue-drain where the initial value is in the queue already and requests are forwarded to the upstream as they are. 👍 |
Thanks @akarnokd |
|
👍 |
stevegury
added a commit
that referenced
this pull request
Feb 24, 2016
scan should pass upstream a request of Long.MAX_VALUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in 1.1.1. for the
scanoperator introduced a bug in requesting where when the initial request was for max value thescanoperator requested one less than that value of upstream (which affects fast-path producers).I believe this bug only affects 1.1.1 (haven't looked at 2.x).
This PR includes a test that failed on the original code.