Operation throttleLast

[benjchristensen]

Merge of #258

[cloudbees-pull-request-builder]

RxJava-pull-requests #258 SUCCESS
This pull request looks good

[benjchristensen]

NOTE: This implementation is modified to use window which differs from the original. It feels simpler but is not exactly the same as was contributed, nor do I think it's an exact match to Rx.Net.

As currently implemented this returns the last value of each window as opposed to restarting the time at each onNext. I'm playing with that implementation next.

I'm curious about when the different types of implementations may be more valuable than others.

[samuelgruetter]

Great! Looking forward to having this operator :)

[benjchristensen]

This will return the last value in each time window. It will always emit at least 1 value in each window.

        PublishSubject<Integer> o = PublishSubject.create();
        o.throttleLast(500, TimeUnit.MILLISECONDS, s).subscribe(observer);

        // send events with simulated time increments
        s.advanceTimeTo(0, TimeUnit.MILLISECONDS);
        o.onNext(1); // skip
        o.onNext(2); // deliver
        s.advanceTimeTo(501, TimeUnit.MILLISECONDS);
        o.onNext(3); // skip
        s.advanceTimeTo(600, TimeUnit.MILLISECONDS);
        o.onNext(4); // skip
        s.advanceTimeTo(700, TimeUnit.MILLISECONDS);
        o.onNext(5); // skip
        o.onNext(6); // deliver
        s.advanceTimeTo(1001, TimeUnit.MILLISECONDS);
        o.onNext(7); // deliver
        s.advanceTimeTo(1501, TimeUnit.MILLISECONDS);
        o.onCompleted();

Compare this with #366

[benjchristensen]

Please review this behavior and let me know if it is accurate and if the name is explanatory.

[benjchristensen]

Javadoc:

Throttles to last value in each window.

[benjchristensen]

I have submitted 3 separate pull requests with different variants of throttle. I would appreciate feedback on them:

• is the name and javadoc descriptive?
• does the throttling strategy make sense?

Variants are:

• throttleWithTimeout: Operator: throttleWithTimeout #366
• throttleLast: Operation throttleLast #365
• throttleFirst: Operator: throttleFirst #367

[DavidMGross]

Would you summarize for me how this differs from sample()?

On Tue, Sep 10, 2013 at 12:17 AM, Ben Christensen
notifications@github.comwrote:

I have submitted 3 separate pull requests with different variants of
throttle. I would appreciate feedback on them:

• is the name and javadoc descriptive?
• does the throttling strategy make sense?

Variants are:

• throttleWithTimeout: Operator: throttleWithTimeout #366Operator: throttleWithTimeout #366
• throttleLast: Operation throttleLast #365 Operation throttleLast #365
• throttleFirst: Operator: throttleFirst #367 Operator: throttleFirst #367

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/365#issuecomment-24138547
.

[benjchristensen]

The throttleLast is absolutely the same as sample it appears, so I'll remove throttleLast.