handle predicate exceptions properly in skipWhile #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unrelated unit test failure |
|
👍 |
1 similar comment
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Jan 24, 2016
handle predicate exceptions properly in skipWhile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-fatal exception thrown by
predicate.call()inOperatorSkipWhilecould result in the error being reported by an upstream operator. This PR ensures that the error is reported by the operator in which it occurs.I've added a unit test for this scenario that failed with the original code, and a couple of other tests.
There are a few more of these floating around that I'll submit PRs for as well.