Better null tolerance in rx.exceptions.*Exception classes. #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Code is 👍, but not sure I like null tolerance for exceptions… |
|
The problem is that NPEs will crash the streams further and likely end up hanging somewhere. |
|
Yeah, I understand… Okay, I guess. |
akarnokd
added a commit
that referenced
this pull request
Oct 19, 2015
Better null tolerance in rx.exceptions.*Exception classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a tendency to send
nullvalues throughonErrorwhich eventually causes repeated failures. This PR converts thesenullvalues intoNullPointerExceptions so the error origin is can be discovered and prevents the XXXExceptions from throwing NPEs in their constructors as well.I've also added some missing javadoc.