GroupBy backpressure fix #3428
Merged
GroupBy backpressure fix #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following test starts breaking with this branch. It prints out 1 to 128 then stops and does not print anything else (apparently no progress is made). In branch 1.x this continues to print past 128. range(1, RxRingBuffer.SIZE *4).repeat()
.groupBy((d) -> d)
.flatMap((go) ->
go.doOnNext(System.out::println)
.subscribeOn(Schedulers.io())
)
.subscribe(); |
|
This is because the lack of horizontal unboundedness of flatMap and the bug in groupBy together made it work in 1.0.14. If I run this code with the 2.x fix and add 1024 as the max concurrency value, it prints lots of values indefinitely. |
markrietveld
added a commit
to markrietveld/RxJava
that referenced
this pull request
Nov 3, 2015
To avoid the conflicts with ReactiveX#3428
| public void call(GroupedObservable<Object, Integer> g) { | ||
| g.subscribe(); | ||
| } | ||
| }) // this will request Long.MAX_VALUE |
There was a problem hiding this comment.
Is this comment meant for the inner observable? The outer observable gets a request of 128.
akarnokd
force-pushed
the
GroupByBackpressureFix1x
branch
from
627c658
to
6caf9c6
Compare
|
I've updated the comments. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the 2.x GroupBy operator which solves #3425.
One unit test in OperatorRetryTest had to be altered a bit. I believe
the original code relied on a GroupBy behavior which caused the bug in
#3425.