Backpressure support for most BufferUntilSubscriber use places. #3050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added backpressure support to
BufferUntilSubscriber
, however, the internal workings ofgroupBy
were in conflict with my 'clean' approach. Therefore, I kept the originalBufferUntilSubscriber
use ingroupBy
and addedBufferUntilSubscriberV2
and made the variouswindow()
operators use it instead.I've also added a two unbounded Spsc queue implementations from JCTools which can reduce the allocation-rate of these linked-node queues.
The problem with
groupBy
seems to be that it sets a producer on theSubscriber
before it is actually subscribed to theBufferUntilSubscriber
. The V2 however sets its on producer to support proper replay and kicks out the original coordinator producer. I don't know how to make the two work together yet. Maybe thegroupBy
has to be rewritten from scratch and inline the group backpressure support, request coordination and queueing more directly. An alternative might be to expose the single child request amount inBufferUntilSubscriber
through a callback to the group somehow.