Observable.from(iterable) - ensure it.hasNext() is not called unnecessarily #3006 #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You forgot to implement ``remove()` which is only default in Java 8. |
|
Ta, fixed. |
|
Still it doesn't compile: /home/travis/build/ReactiveX/RxJava/src/test/java/rx/internal/operators/OnSubscribeFromIterableTest.java:233: error: <anonymous rx.internal.operators.OnSubscribeFromIterableTest$4$1> is not abstract and does not override abstract method remove() in Iterator |
|
woops, there were two of them. Fixed. |
|
LGTM 👍 |
|
Thanks! |
akarnokd
added a commit
that referenced
this pull request
Jun 9, 2015
Observable.from(iterable) - ensure it.hasNext() is not called unnecessarily #3006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #3006.
Ensured
it.hasNext()not called more often than required especially when unsubscription happens before completion.Added two unit tests (one for fast path and the other for backpressure) that failed on previous codebase.